search

paulegradie / Sailfish

Sailfish - a production-friendly performance benchmark runner for .NET
https://paulgradie.com/Sailfish/
MIT License
11 stars 5 forks source link

Replace MemoryCache with ExecutionState #182

Closed paulegradie closed 1 month ago

paulegradie commented 1 month ago

Description

It was previously pointed out that MemoryCache can cause bugs in Sailfish due to behavior around data eviction. This PR introduces an InstancePerDependency registered cache clase that replaces MemoryCache

Fixes: https://github.com/paulegradie/Sailfish/issues/180

paulegradie commented 1 month ago

Damn - need to update the actions.

https://github.blog/news-insights/product-news/get-started-with-v4-of-github-actions-artifacts/

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.12%. Comparing base (d7365ef) to head (36510bc). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...urce/Sailfish/Execution/SailfishExecutionEngine.cs 80.96% 3 Missing and 1 partial :warning:
source/Sailfish/Execution/ExecutionState.cs 82.36% 2 Missing and 1 partial :warning:
...estAdapter/Execution/TestAdapterExecutionEngine.cs 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #182 +/- ## ========================================== - Coverage 72.34% 72.12% -0.21% ========================================== Files 317 318 +1 Lines 8480 8503 +23 Branches 968 969 +1 ========================================== - Hits 6134 6132 -2 - Misses 2029 2053 +24 - Partials 317 318 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.