pauleve / docker-mtgo

Docker image with ready-to-play MTGO (Magic Online) for Linux and macOS
https://hub.docker.com/r/panard/mtgo/
483 stars 34 forks source link

MTGO update broke program. #79

Closed jakethekoenig closed 4 years ago

jakethekoenig commented 4 years ago

The March 25th, 2020 MTGO update has seemed to break things. I've attached the output of ./run_mtgo Let me know if you want more information about the error. error.log

somethingstranger commented 4 years ago

@kylesnowschwartz I realized I split up one of the lines, reentered everything, and was able to open the client. However, still got a crash inside limited.

last login 3.txt

somethingstranger commented 4 years ago

When it crashes, I think this is the line that starts it: "008e:err:eventlog:ReportEventW L"Application: MTGO.exenFramework Version: v4.0.30319nDescription: The process was terminated due to an unhandled exception.nException Info: exception code c0000005, exception address F4C2D8D6n" wine: Unhandled page fault on read access to 0x00000000 at address 0xf4c2d8d6 (thread 008e), starting debugger..." because MTGO will run for a while perfectly fine before quitting at some stage. In fact, I think it's doing a vintage draft for me right now since it keeps quitting :p really appreciate everyone who has been helping out on this.

pauleve commented 4 years ago

Thanks for the feedback. I'll try to integrate the script in a generic way. The good thing is that it may remove the need for the wine patch which would be easier for macOS users.

@somethingstranger I'll try to do more games here to try to reproduce this..

Uzay-G commented 4 years ago

For those having managed to start MTGO but with crashes, can you try the following (copy paste to be sure), witthout doing any reset:

./run-mtgo --shell
cfg=$(find .wine/host/ -name user.config )
cat > "$cfg" <<EOF
<?xml version="1.0" encoding="utf-8"?>
<configuration>
    <userSettings>
        <Shiny.Properties.Settings>
            <setting name="PlayStartupSound" serializeAs="String">
                <value>False</value>
            </setting>
        </Shiny.Properties.Settings>
    </userSettings>
</configuration>
EOF
find .wine/host -name Audio -type d -exec mv -v {} {}.old \;
mtgo

regarding black windows, it seems to related to #17 @Rango77 try chmod +x run-mtgo

When I run the first part of this script (right after the second EOF) I get bash: : No such file or directory

Rango77 commented 4 years ago

Yes, Uzay-G I'm having the same problems, to which pauleve offered me to try

Rango77 commented 4 years ago

chmod +x run-mtgo

Rango77 commented 4 years ago

I still get the same error message though.

pauleve commented 4 years ago

Here is a first attempt of script to disable startup sound (only when not using Docker!), which maybe works on macOS as well (after having following the instructions at https://github.com/pauleve/docker-mtgo/wiki/macOS:-installing-MTGO-using-Wine), and does not require patching wine.

curl -fOL https://raw.githubusercontent.com/pauleve/docker-mtgo/master/extra/mtgo-no-startupsound.sh
bash mtgo-no-startupsound.sh

It is integrated in the Docker image, so you just have to run

./run-mtgo --update

I'm still experiencing crashes at EULA stage (the same as @somethingstranger ) depending on the configuration, I'm trying to figure out what is happening...

Others commented 4 years ago

I think I have the same EULA crash. Here is my log if it is helful: run_mtgo_log.txt

pauleve commented 4 years ago

Thanks. Yes it is the same crash. I'll investigate a bit further, in the worst case I'll bypass the EULA validation..

pauleve commented 4 years ago

@Rango77 please copy and paste everything from the run-mtgo command

Rango77 commented 4 years ago

Tried that, same thing.

./run-mtgo --reset --update panard/mtgo:pr73 --shell -bash: ./run-mtgo: No such file or directory

Same message with chmod +x run-mtgo

Thank you for the help.

pauleve commented 4 years ago

@Rango77 please follow carefully the README https://github.com/pauleve/docker-mtgo/blob/master/README.md:

curl -o run-mtgo https://raw.githubusercontent.com/pauleve/docker-mtgo/master/run-mtgo
chmod +x run-mtgo
newfiepro commented 4 years ago

I attempted to follow the instructions to use it through the docker (I'm on macOS so was just using wine) It told me I needed to input my password to continue but wouldn't allow me to put it in.

pauleve commented 4 years ago

@newfiepro can you try again without docker and using the two commands I put above in https://github.com/pauleve/docker-mtgo/issues/79#issuecomment-605491924 (with mtgo-no-startupsound.sh)

somethingstranger commented 4 years ago

@newfiepro if your password doesn't show up, it's still seeing your typing it, just not putting it on screen. just type out the full password and press enter.

@pauleve anything I can do to help with the EULA error?

kylesnowschwartz commented 4 years ago

Description

When running MTGO using the docker container, the game crashes when attempting to play cards, or when starting a match

Reproduction

I ran the recent ./run-mtgo --update command to grab the latest image, which I believe has the sound disabling patch integrated. I also attempted to run in the shell and copy the paste the EOF manually, and also in combintation of running winetricks quartz in the shell. All result in the application crashing.

This was after some success playing several matches last night, so I'm unsure how to account for the change in stability.

I've attached the --debug error log error.log

Rango77 commented 4 years ago

pauleve,

I went through the README. Everything seemed to work until I reached

chmod +x run-mtgo

When I pressed enter, the terminal just just skipped a line and wouldn't run anything.

pauleve commented 4 years ago

@kylesnowschwartz I have the same experience now.. it crashes whenever it should be a sound..

pauleve commented 4 years ago

@Rango77 please open a separate issue, and paste the output of all the commands, including curl

Rango77 commented 4 years ago

Will do.

pauleve commented 4 years ago

@kylesnowschwartz funnily enough, I'm no longer experiencing the crash when doing the following:

./run-mtgo --shell
winedbg /opt/mtgo/mtgo.exe

then press c.

Do you confim?

kylesnowschwartz commented 4 years ago

so close @pauleve

Unfortunately I performed a --reset as part of my trial and erroring, and now I'm blocked behind the EULA crash.

pauleve commented 4 years ago

Ok.. I seem to have much less crash probability with ./run-mtgo panard/mtgo:pr73, but it is really random..

kylesnowschwartz commented 4 years ago

Ok.. I seem to have much less crash probability with ./run-mtgo panard/mtgo:pr73, but it is really random..

Yes this unblocks the EULA crash!

kylesnowschwartz commented 4 years ago

And we're off and away playing well using ./run-mtgo panard/mtgo:pr73 not even using the shell or any of the other tricks

pauleve commented 4 years ago

Still experiencing it from time to time with this image.. we're not done apparently :'(

somethingstranger commented 4 years ago

Has anyone gotten everything to work with no issues? If so, what did you do?

pauleve commented 4 years ago

I'm having no issue so far using wine outside of docker, with the latest wine for Ubuntu, the appropriate winetricks, and the script I mentioned above to disable startup sound. Will give more try later..

pauleve commented 4 years ago

According to feedback in https://www.reddit.com/r/MTGO/comments/fp6hxx/problem_booting_mtgo_via_wine_staging_on_mac_w/flsbzl5 the script seems to work on macOS (without Docker). I've updated the instructions at https://github.com/pauleve/docker-mtgo/wiki/macOS:-installing-MTGO-using-Wine ; it is rather equivalent for linux, except the wine installation part.

pauleve commented 4 years ago

Time to close this bug:

If you have an error with the above script, please open a new issue.

For those experiencing the crash, let's move to #83

pauleve commented 4 years ago

Apparently I found a workaround for the crashes, see #83 and keep me in touch there.

wjadams80 commented 4 years ago

pauleve, thank you so much for your help with this!

I downloaded and installed Wine 5.6 for my Mac laptop, based on your notes here. I'm running Mac OS Mojave, version 10.14.6. When I open Wine Staging 5.6 and execute the line:

wine mtgo.exe

from the prompt, the wine-preloader just takes me to a Wine Internet Explorer showing the URL: http://mtgoclientdepot.onlinegaming.wizards.com/MTGO.application

Screenshot attached of what I see:

Screen Shot 2020-04-16 at 12 37 11 AM

Have I missed a step somewhere? Thank you again so much for all of the work you've done to help us figure this out!

Best, Bill

pauleve commented 4 years ago

Please follow carefully the instructions at https://github.com/pauleve/docker-mtgo/wiki/macOS:-installing-MTGO-using-Wine; and open a separate issue if you still have one.