Finalizing HTML compiler

pauleveritt / fdom

Template engine based on tag strings and functional ideas.

0 stars 0 forks source link

Finalizing HTML compiler #10

Open jimbaker opened 12 months ago

jimbaker commented 12 months ago

Next steps for MVP:

[x] Remove localization, LOAD_ATTR/LOAD_GLOBAL specialization should be fine
[x] Re-enable compiler caching, and generalize the setup so it's not specific to one runtime
[x] Validate tag and attribute names, otherwise raise ValueError
[ ] Apply conversions/format spec
[ ] Full test coverage and any bug fixes
[ ] Self documenting - this should be a good example for the tagstr PEP
[ ] Find Jinja examples for generating HTML, port to tag string usage, and compare performance

jimbaker commented 11 months ago

Further steps:

[x] Preserve original formatting, specifically whitespace
[ ] Do so when nested (with textwrap.indent)
[ ] Ensure that interpolated tag names properly nest with a suitable constraint setup
[ ] Raise validation errors (presumably ValueError, or subclass) that refer to the original source, including expression text and its location (row/col).

jimbaker commented 11 months ago

I was looking in Jinja's code for some good example Jinja templates from a performance perspective, but I didn't see any there. (Instead templates were focused on tests, which seem to be of limited applicability given that we assume more of the overall Python environment - imports, functions, etc just exist, and are extensively tested in Python itself.)

However, it was interesting to see some similarities in the code generation here - https://github.com/pallets/jinja/blob/main/src/jinja2/compiler.py#L300 including specifically the use of yield.