Guidebook doesn't open in hand

paulevsGitch / BetterEnd

Better End MC Mod

MIT License

100 stars 81 forks source link

Guidebook doesn't open in hand #399

Open MJRamon opened 2 years ago

MJRamon commented 2 years ago

BCLib 1.2.2 BetterEnd 1.0.0

It opens only on lectern.

paulevsGitch commented 2 years ago

What mod version are you using? What are in game logs?

MJRamon commented 2 years ago

No logs. Mod versions are in first message.

paulevsGitch commented 2 years ago

No logs

What do you mean? Game always logs everything that is happening into logs folder

Mod versions are in first message.

I mean Patchouli version

MJRamon commented 2 years ago

Patchouli-1.18.1-64-FABRIC

I mean, no information about this problem in log files.

paulevsGitch commented 2 years ago

BetterEnd book is added with Patchouli API, so there can be two reasons:

API was changed and now require some additional json information
Patchouli has bug in its book items

If your Patchouli version is not latest try to update it. I can also recommend post same issue on Patchouli tracker

Hubry commented 2 years ago

https://github.com/paulevsGitch/BetterEnd/blob/417350db2db9c5bd247cd50657e96d0794f96236/src/main/java/ru/betterend/item/GuideBookItem.java#L35-L36

Looks like your fault.

Zarepheth commented 2 years ago

@paulevsGitch, I think you misunderstood @Hubry. It appears that BetterEnd has commented out Patchouli support and someone needs to reenable it.

Brittank88 commented 2 years ago

So literally one line of code needs to be uncommented? Darn, I hope that's resolved soon if it's truly that simple. Understandable if it isn't though.

Brittank88 commented 2 years ago

Ah, nevermind, just learned about the new repo: https://github.com/quiqueck/BetterEnd