paulevsGitch / BetterEnd

Better End MC Mod
MIT License
101 stars 83 forks source link

Music Discs do not play with CC:Restitched #471

Open Merith-TK opened 2 years ago

Merith-TK commented 2 years ago

literally just bouncing this to this issue tracker https://github.com/cc-tweaked/cc-restitched/issues/89

Hello, I am currently playing in a minecraft 1.18.1 Fabric modpack with 100+ mods including cc-restitched-1.100.3. One of the mods in the modpack adds music discs, that is the Better End mod (located here: https://www.curseforge.com/minecraft/mc-mods/betterend). I've been having some troubles playing these music discs from the mod in CC:Restitched Disk Drives. The Drives can read the titles of the discs and "play" the discs, but there is no audio when they're being played. I've tried playing the disc in a jukebox and it works perfectly fine. Its just that when it gets "played" in the CC:Restitched disk drive that it has no audio. Other music discs from other mods like Anchor and Actually Additions work as you'd expect.

quiqueck commented 2 years ago

Hi, and thanks for reporting this to us. I must say, that the authors reply is oddly aggressive :( No promises, but we'll have a look if there is something we can do to mitigate the issue.

Merith-TK commented 2 years ago

Hi, and thanks for reporting this to us. I must say, that the authors reply is oddly aggressive :( No promises, but we'll have a look if there is something we can do to mitigate the issue.

I am the Author for CC:R, sorry, I am just over all frustrated with Better End because I ran an 1.16.5 server for an while with it, and even went to the discord for support as we used BlueMap to render an 3d map of the place, and BE at the time used three different methods for leaves, two of which were not supported by bluemap so they showed up as missing texture blocks, and 1 person existing in The End, just existing, on the end island, brought the server to its knees with roughly 6gb of ram at the time.

The responses I got on the discord AND here on github from paul themself have left an sour taste in my mouth about this mod in general. see #266 for an example of this, where Paul claimed that every block in the mod used the exact same method as each other to be generated and rendered, while bluemap revealed this was not the case, as if that was the case, every block would either be working right, or not.

So I currently do not trust issues related to BE, are not BE's fault. especially if another mod's implementation of the same function (in this case, music discs) work just fine, if the fault does turn out to actually be on CC:R, and not an result of BE's weirdness, let us know with where the fault appears to be,

quiqueck commented 2 years ago

Hi, and thanks for giving me the broader picture, I really appreciate it! I am sorry to hear that there were problems in the past.