search

paulevsGitch / BetterNether

BetterNether Mod
GNU General Public License v3.0
105 stars 73 forks source link

[Bug] TerraBlender, Terralilith, BetterNether/End Crash #503

Closed greensad closed 2 years ago

greensad commented 2 years ago

What happened?

After extensive testing I've confirmed that using TerraBlender, Terralilith, Better Nether or Better End in conjunction will crash the game when creating a new world, removing any one of these mods will allow the game to create a new world normally. BCLib without Better Nether or Better End will allow the game to create a new world normally. I've never encountered a crash like this before and so I'm not sure where the best place to post the issue would be so I'm opening an issue here and on TerraBlender's issue tracker as well: https://github.com/Glitchfiend/TerraBlender/issues/22

BetterNether

6.0.9

BCLib

1.2.5

Fabric API

0.46.1

Fabric Loader

0.12.12

Minecraft

1.18.1

Relevant log output

https://bytebin.lucko.me/VITCgd380c or https://crashy.net/pBp1LPn4rD8799dniMXP

**MultiMC Instance:** https://drive.google.com/file/d/1m5v6mpfDx3uHTJoUwXLfVbefaxp7x4IO/view?usp=sharing

Other Mods

Better End 1.0.1
Terralilith 2.0.12
TerraBlender 1.1.0.70
Not Enough Crashes 4.1.4
quiqueck commented 2 years ago

Hm, from what I see this is due to cclic serialization of surface rules. Not sure why that is happening tho...

quiqueck commented 2 years ago

Hm, I think something is choking on our custom SurfaceRule Conditions when TerraBlender is present.

TheButterbrotMan commented 2 years ago

@quiqueck Is there any ETA for the fix? Probably could it take minutes, hours, days, weeks, years? :D ;)

paulevsGitch commented 2 years ago

Fix is already in code, so it will be in next release of BCLib

quiqueck commented 2 years ago

I am currently testing the fix, and BetterEnd may also need some updating.

greensad commented 2 years ago

Phenomenal work and initiative thus far to y'all!

TheButterbrotMan commented 2 years ago

Fix is already in code, so it will be in next release of BCLib

So, when will the next update release? Im really looking forward to it.

quiqueck commented 2 years ago

The Fix for this crash should be in 6.0.10. Please re-open this issue if you still have the crash after upgrading. However, be aware that BetterNether and TerraBlender are still not compatible. We continue to track that progress in #504