[Bug] Fireflies are not rendered correctly

DryTaste commented 2 years ago

What happened?

Fireflies and some other mobs exhibit visual glitches as can be seen in the screenshot provided below;

glitch

BetterNether

6.0.9

BCLib

1.2.5

Fabric API

0.46.1

Fabric Loader

0.12.12

Minecraft

1.18.1

Relevant log output

No response

Other Mods

Canvas 1.0.2302 (same results with 1.0.2282)
Better end 1.0.1

paulevsGitch commented 2 years ago

I guess the reason is incompat with Canvas:

Canvas 1.0.2302

DryTaste commented 2 years ago

I guess the reason is incompat with Canvas:

Canvas 1.0.2302

After some testing that seems to be the case.

paulevsGitch commented 2 years ago

I think that canvas require custom shaders for such entity rendering, this is also related to #484

DryTaste commented 2 years ago

For anyone coming across this issue;

The bug/glitch is way less obnoxious when using Iris & Sodium with "complimentary shaders" installed. Especially so if you disable PR support in the shader settings. This seems to be the superior option because you will enjoy greater mod compatability (canvas breaks stuff like immersive portals and smooth water color transitions in BetterEnd) and will also benefit both the emissive textures this mod has to offer and the peformance increase by sodium.

The only drawbacks to this is that the end nebula skybox seems to break and when disabling PR support some things stop glowing (like chorus flowers in the end). This is a trade off descision you have to make.

The ideal solution would be to find a shader for Iris + Sodium that enables emissives/bloom but nothing else.

quiqueck commented 2 years ago

The next version should fix this for Iris. Canvas needs more work tho, and we will track that in #484

quiqueck commented 2 years ago

The Fix should be in 6.0.10. Please re-open this issue if you still have problems after upgrading.

paulevsGitch / BetterNether