search

paulevsGitch / BetterNether

BetterNether Mod
GNU General Public License v3.0
105 stars 73 forks source link

[Bug] Missing recipes when referenced by ResourceLocation #514

Closed TheIllusiveC4 closed 2 years ago

TheIllusiveC4 commented 2 years ago

What happened?

Polymorph developer here again. I was investigating a new issue that popped up on my end (https://github.com/TheIllusiveC4/Polymorph/issues/145) and realized that this is likely the same issue as the one that was discussed for BetterEnd (https://github.com/paulevsGitch/BetterEnd/issues/405).

It's better summarized in the old issue, but just to briefly recap: Due to the way that recipes are stored and merged from BetterNether, any calls to RecipeManager#byKey(ResourceLocation) will not return the proper values for BetterNether recipes. The solution is to merge the recipes into the secondary HashMap that holds these references keyed by ResourceLocation, in addition to the current map that is keyed by RecipeType.

BetterNether

6.0.10

BCLib

1.3.4

Fabric API

0.46.4+1.18

Fabric Loader

0.12.12

Minecraft

1.18.1

Relevant log output

No response

Other Mods

No response

paulevsGitch commented 2 years ago

All recipes are already added into second map, is this report for outdated version?

paulevsGitch commented 2 years ago

Hm, I just saw 1.3.4 version, this should not happen

paulevsGitch commented 2 years ago

All recipes are added into both maps

paulevsGitch commented 2 years ago

I think I know the reason - BN still uses its own old recipe manager, @quiqueck, please fix this

quiqueck commented 2 years ago

This should be fixed in 6.0.11. Please re-open this issues if you are still having problems.