paulevsGitch / BetterNether

BetterNether Mod
GNU General Public License v3.0
105 stars 72 forks source link

[Bug] some biomes not creating anything but the ground "grass" only in random places though. #551

Closed JonCaver closed 2 years ago

JonCaver commented 2 years ago

What happened?

Some of the biomes will be created without anything but the "grass". Only in random places though. Seems most common in the Bone Reef and its variants. like this picture will show. I saw a post about this a little down the list but they had some generation besides just the "grass 2022-05-16_18 44 33 latest.log "

BetterNether

6.1.1

BCLib

1.4.6

Fabric API

0.51.1

Fabric Loader

0.14.2

Minecraft

1.18.1

Relevant log output

No response

Other Mods

- additionalstructures 3.0.3
    - advancedcombat 1.0-SNAPSHOT
    - adventurez 1.4.10
    - amplified-nether 1.1
    - appleskin 2.4.0+mc1.18.2
    - architectury 4.4.54
    - badpackets 0.1.2
    - bclib 1.4.6
    - betteranimalsplus 1.18.2-11.0.5
    - betterbeacon 1.0.8
    - betterdungeons 1.18.2-Fabric-2.1.0
    - betterend 1.1.0
    - bettermineshafts 1.18.2-Fabric-2.1.3
    - betternether 6.1.1
    - bettershields 0.0.1-1.18.2
    - betterstrongholds 1.18.2-Fabric-2.1.1
    - biomemakeover 1.18.2-1.4.20
    - blue_endless_jankson 1.2.1 via kyrptconfig
    - blur 2.4.1
    - bole 1.0.5-mc1.18.2-fabric
    - bookshelf 13.0.8
    - borderlessmining 1.1.2+1.18.2
    - bsvsb 2.0.5
    - byg 1.4
    - bygplus 2.0.1
    - caffeineconfig 1.1.0 via sodium-extra
    - cardinal-components-base 4.1.4 via pollen
    - cardinal-components-entity 4.1.4 via pollen
    - cloth-basic-math 0.6.0 via cloth-config
    - cloth-config 6.2.57
    - clumps 8.0.0+8
    - collective-fabric 4.26
    - colytra 2.1.0-1.18.1
    - com_electronwill_night-config_core 3.6.5 via couplings
    - com_electronwill_night-config_toml 3.6.5 via couplings
    - com_eliotlash_mclib_mclib 18 via geckolib3
    - com_eliotlash_molang_molang 18 via geckolib3
    - consistency_plus 0.5.0+1.18.2
    - continuity 1.1.0+1.18.2
    - couplings 1.8.0+1.18.2
    - craftingpad 1.0.8
    - creeperspores 1.8.0
    - customportalapi 0.0.1-beta50-1.18 via mining_dims
    - dark-loading-screen 1.6.11
    - detailab 2.6.2+1.18-fabric
    - dimheight 1.1.1
    - disable_custom_worlds_advice 2.0
    - effective 1.2.1
    - elden_horses 1.0.0+1.18.2
    - enchdesc 10.0.2
    - enhanced_mushrooms 4.0.0
    - entityculling 1.5.1
    - fabric 0.51.1+1.18.2
    - fabric-api-base 0.4.4+d7c144a860 via fabric
    - fabric-api-lookup-api-v1 1.6.0+2373a54560 via fabric
    - fabric-biome-api-v1 8.0.4+7b0f312660 via fabric
    - fabric-blockrenderlayer-v1 1.1.12+3ac43d9560 via fabric
    - fabric-command-api-v1 1.1.9+d7c144a860 via fabric
    - fabric-commands-v0 0.2.8+b4f4f6cd60 via fabric
    - fabric-containers-v0 0.1.21+d7c144a860 via fabric
    - fabric-content-registries-v0 3.0.3+d82b939260 via fabric
    - fabric-convention-tags-v1 1.0.1+474e4f7960 via fabric
    - fabric-crash-report-info-v1 0.1.11+3ac43d9560 via fabric
    - fabric-dimensions-v1 2.1.17+2540745460 via fabric
    - fabric-entity-events-v1 1.4.8+d7c144a860 via fabric
    - fabric-events-interaction-v0 0.4.19+d7c144a860 via fabric
    - fabric-events-lifecycle-v0 0.2.14+d7c144a860 via fabric
    - fabric-game-rule-api-v1 1.0.13+d7c144a860 via fabric
    - fabric-item-api-v1 1.4.0+4457765560 via fabric
    - fabric-item-groups-v0 0.3.11+91896a4960 via fabric
    - fabric-key-binding-api-v1 1.0.12+54e5b2ec60 via fabric
    - fabric-keybindings-v0 0.2.10+b4f4f6cd60 via fabric
    - fabric-language-kotlin 1.7.4+kotlin.1.6.21
    - fabric-lifecycle-events-v1 2.0.3+2d83e92c60 via fabric
    - fabric-loot-tables-v1 1.0.11+d7c144a860 via fabric
    - fabric-mining-level-api-v1 2.1.0+81ea5b3c60 via fabric
    - fabric-models-v0 0.3.6+d7c144a860 via fabric
    - fabric-networking-api-v1 1.0.21+d882b91560 via fabric
    - fabric-networking-v0 0.3.8+b4f4f6cd60 via fabric
    - fabric-object-builder-api-v1 2.1.0+fe4ddef060 via fabric
    - fabric-particles-v1 0.2.12+526dc1ac60 via fabric
    - fabric-registry-sync-v0 0.9.8+0d9ab37260 via fabric
    - fabric-renderer-api-v1 0.4.13+d882b91560 via fabric
    - fabric-renderer-indigo 0.5.0+7faf0d8860 via fabric
    - fabric-renderer-registries-v1 3.2.11+b4f4f6cd60 via fabric
    - fabric-rendering-data-attachment-v1 0.3.7+d7c144a860 via fabric
    - fabric-rendering-fluids-v1 2.0.2+54e5b2ec60 via fabric
    - fabric-rendering-v0 1.1.13+b4f4f6cd60 via fabric
    - fabric-rendering-v1 1.10.7+54e5b2ec60 via fabric
    - fabric-resource-conditions-api-v1 2.0.3+91b7aa6660 via fabric
    - fabric-resource-loader-v0 0.4.18+2de5574560 via borderlessmining
    - fabric-screen-api-v1 1.0.10+d882b91560 via fabric
    - fabric-screen-handler-api-v1 1.2.0+1f6558e860 via fabric
    - fabric-textures-v0 1.0.12+3ac43d9560 via fabric
    - fabric-transfer-api-v1 1.6.0+2373a54560 via fabric
    - fabric-transitive-access-wideners-v1 1.0.0+bd8a4a1860 via fabric
    - fabricloader 0.14.2
    - fallingleaves 1.11.1+1.18.2
    - fallingtree 3.5.1
    - feature_nbt_deadlock_be_gone 2.0.0+1.18.2-rc1
    - fiber 0.23.0-2 via collective-fabric
    - geckolib3 3.0.36
    - geodes 1.4
    - gobber2 2.5.74
    - goosik-config 0.2.0 via visuality
    - graveyard 1.8
    - graveyard_biomes 1.1
    - guardvillagers 1.18.2-1.0.14
    - illuminations 1.10.4
    - immersive_weathering 2.4.0
    - indium 1.0.3+mc1.18.2
    - inmis 2.6.0-1.18.2
    - inventorio 1.7.0
    - inventoryhud 3.4.2
    - inventorytotem-fabric 1.5
    - invisibilitycloak 2.0.1
    - iris 1.2.4-build.38
    - jankson 4.0.0+j1.2.0 via libgui
    - java 17
    - just_end_anchor 1.0.2
    - kirin 1.10.0 via presencefootsteps
    - kyrptconfig 1.3.4-1.18 via quickshulker
    - lambdabettergrass 1.2.3+1.18
    - lazydfu 0.1.2
    - libgui 5.3.2+1.18.2 via probablychests
    - libninepatch 1.1.0 via libgui
    - libraryferret 1.0.3
    - lithium 0.7.9
    - midashunger 2.1.0+1.18.2
    - midnightlib 0.3.1 via blur
    - minecraft 1.18.2
    - mining_dims 1.3.5
    - mm 2.3 via shulkerboxtooltip
    - modmenu 3.2.1
    - morebannerfeatures 1.1.3
    - morevillagers-fabric 3.2.0-SNAPSHOT
    - mostructures 1.4.2+1.18.2
    - nocreativedrift 1.18-3.0.4.0-fabric
    - omega-config 1.2.3-1.18.1 via inmis
    - org_anarres_jcpp 1.4.14 via iris
    - org_jetbrains_kotlin_kotlin-reflect 1.6.21 via fabric-language-kotlin
    - org_jetbrains_kotlin_kotlin-stdlib 1.6.21 via fabric-language-kotlin
    - org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.6.21 via fabric-language-kotlin
    - org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.6.21 via fabric-language-kotlin
    - org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.6.1 via fabric-language-kotlin
    - org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.6.1 via fabric-language-kotlin
    - org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.3.2 via fabric-language-kotlin
    - org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.3.2 via fabric-language-kotlin
    - org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.3.2 via fabric-language-kotlin
    - org_joml_joml 1.10.2 via sodium
    - owo 0.6.0+1.18
    - patchouli 1.18.2-67-FABRIC
    - paxi 1.18.2-Fabric-2.0
    - pollen 1.4.1
    - presencefootsteps 1.5.0
    - probablychests 0.4.3
    - pugh_lib 1.3.0 via gobber2
    - pugh_tools 1.2.5 via gobber2
    - quickshulker 1.3.6-1.18
    - reaping 2.0.2
    - reeses-sodium-options 1.4.2
    - reinfbarrel 2.0.0+1.18
    - reinfchest 2.0.0+1.18
    - reinfcore 2.0.0+1.18 via reinfbarrel
    - reinfshulker 2.0.0+1.18
    - repurposed_structures 4.1.7+1.18.2
    - roughlyenoughitems 8.1.457
    - satin 1.7.0 via blur
    - shulkerboxtooltip 3.0.7+1.18.2
    - shulkerutils 1.0.4-1.18 via quickshulker
    - skinlayers 1.4.3-mc1.18.2
    - smoothboot 1.18.2-1.7.0
    - sodium 0.4.1+build.15
    - sodium-extra 0.4.4+mc1.18.2-build.39
    - spruceui 3.3.3+1.18 via lambdabettergrass
    - spyglass-improvements 1.2+mc1.18.2+fabric
    - stacc 1.3.0 via stacker
    - stacker 2.1.3
    - steves_vanilla 1.1.0+1.18
    - stonecutter_recipe_tags 3.0.1+1.18.bc850d5.fabric via consistency_plus
    - stoneholm 1.4.3
    - tawct 1.4.2+1.18.2
    - terrablender 1.1.0.99
    - tlcosmetica 0.4.0 via visuality
    - toms_storage 1.3.1
    - totw_additions 1.2.0
    - tree-hollows 1.3.3
    - tree-hollows-core 1.3.3 via tree-hollows
    - trinkets 3.3.0
    - twigs 1.1.3-patch1+1.18.2
    - valley 2.3-1.18.2
    - vehiclefix 3.3
    - visuality 0.4.2
    - walllanterns 1.0.1
    - wandering_trapper 1.2.0
    - waystones 2.5.1
    - whisperwoods 1.18.2-2.1.0
    - wthit 4.10.3
    - xaerominimap 22.7.0
    - xaeroworldmap 1.21.2
    - yigd 1.3.4
    - yungsapi 1.18.2-Fabric-2.0.8
    - yungsextras 1.18.2-Fabric-2.1.0
aisukuma commented 2 years ago

Issue #504, a fix can be found here: https://github.com/paulevsGitch/BetterNether/issues/504#issuecomment-1072988472

aisukuma commented 2 years ago

Oh yeah, make sure you reset your nether for stuff to regenerate by going to your world's folder and deleting the DIM-1 folder.

Note: it will reset any existing builds inside the nether, so make a backup just in case.

JonCaver commented 2 years ago

So doing the force include should look like this?? because that isn't helping and I did delete the Dim_1 folder?? Screenshot 2022-05-16 200708

JonCaver commented 2 years ago

Ok so interesting thing is happening. I did all the "FIX" then went back into the world and searched for the biome and tp to that location (which was further away then the pictured biome) and that one area was generating completely fine!! Not sure why that area in the picture is not generating properly or that it doesnt recognize it in the locate command?? but it shows as "bone reef" on the Mini map. very odd!!

UPDATE: Changed the "vertical" for each biome to "true" and this has fixed the generation!! im no expert as to why but it has worked for me!

quiqueck commented 2 years ago

Thanks for all the testing :) vertical means, that the biome will span the entire world height. Not sure why that would help to fix the issue yet, but it certainly is a clue.

JonCaver commented 2 years ago

It is better with "vertical" turned on!! Not perfect but definitely better!! The upside down forest in the background is almost non-existent in the first photo sent and you can see it clearly generated now!! 2022-05-17_20 56 43

quiqueck commented 2 years ago

Hm, the upside-down forrest should be vertical by default.

paulevsGitch commented 2 years ago

This should work fine in latest (1.18.2 and 1.19) versions (probably). If not - please reopen it on a new BN issue tracker