search

paulevsGitch / EdenRing

MIT License
20 stars 17 forks source link

About Update to 1.18.2 #20

Closed Slarper closed 2 years ago

Slarper commented 2 years ago

Dear paulevsGitch, I don't know whether you has plans to update to minecraft 1.18.2 or you just wanna skip 1.18.2 and update to 1.19.1. But if you want to update EdenRing to 1.18.2, here are some tips. (By the way, if you agree, I can try to pull a request to update EdenRing to 1.18.2, please give me a clear answer.)

  1. NoiseSamplerMixin error: Vanilla package net.minecraft.world.level.levelgen has rewritten. Many classes were turned to [record](https://www.baeldung.com/java-record-keyword). You may find the class NoiseSampler disappeared. Now much of its functionality has been moved to NoiseRouter(But I'm not sure it will work as original).
  2. // To be added
Slarper commented 2 years ago

Oh my god I know why you don't update Eden Ring to 1.18.2, there are too many things rewritten. The error occurring in DimensionTypeMixin makes me confused.

Slarper commented 2 years ago

There is too many changes to speak out.

Slarper commented 2 years ago

After I modifying, I will pull a request.

Slarper commented 2 years ago

I am confused...............BCLib 1.4.0 has released on curseforge, so I fork BCLib's branch 1.18.2. But this branch fills of errors..... Without an usable BCLib, I can't update Eden Ring to 1.18.2