paulevsGitch / EdenRing

MIT License
20 stars 17 forks source link

Eden Ring using 15% of server thread when noone is on it #60

Closed kirchner-trevor closed 2 years ago

kirchner-trevor commented 2 years ago

Modpack: Better MC v9 Minecraft Server: 1.19.2 Fabric: 0.14.9 Eden Ring: 0.6.4 Server Size: ~7 players

I ran a profiler for 30 minutes using spark and it showed that edenring was using 15% of the server thread. Noone on the server had even been to eden ring yet, and noone was on it currently. I would expect eden ring to use 0% of the server thread when no players are in that dimension.

Profiler results: https://spark.lucko.me/cbrKNldw3t

paulevsGitch commented 2 years ago

10% from these 15 are not from Eden, they are from another mod that changes blockstate handler

image

paulevsGitch commented 2 years ago

Yes, it's from BYG. As it checks hash map each time any blockstate is checked it causes performance issues

kirchner-trevor commented 2 years ago

Ahh good catch, sorry I missed that, that makes sense. Thanks for the quick reply!

DougStoker commented 2 years ago
Screen Shot 2022-11-04 at 8 36 12 PM

it still uses quite a bit of resources in singleplayer despite not even have been there yet https://spark.lucko.me/dEicX0PyEY

paulevsGitch commented 2 years ago

This is a normal usage of resources: image

If it is larger than you have other mods that alters blocks logic, or you just have too much entities