Closed OpenBagTwo closed 1 year ago
Ha! Okay, update: placing a gravity compressor crashed the game:
java.lang.IllegalArgumentException: Cannot get property class_2746{name=extended, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{edenring:gravity_compressor}
I'm guessing there's a problem with the piston a mixin...
Anyway, this is why this PR is likely to need a bit more attention than, say, #61
I'm closing this PR, as any port to 1.19.4+ really should be using the new tags system. I may try again, starting from @Treetrain1's 1.19.3 port, but I don't think I'll be reusing much of my own work from this PR.
What's Working
I can construct an Eden Portal
![Portal](https://github.com/paulevsGitch/EdenRing/assets/66568922/3dcb6199-e521-4ac8-8240-67c15dee3836)I can travel to the Eden Ring
![Eden Ring](https://github.com/paulevsGitch/EdenRing/assets/66568922/1eba7c50-8b78-48d5-8d2e-5a22dea1ad87)What's Not
The Eden Ring guidebook is barely legible
![Guidebook](https://github.com/paulevsGitch/EdenRing/assets/66568922/174332e1-3a15-4987-90e0-53c6d1144c93)What I haven't tested
What to Pay Extra Attention to
The most non-obvious changes (read: the ones I probably got wrong) were:
Thank you so much for creating this gorgeous mod--there's nothing like spending a day and a half poring over someone's codebase to make you appreciate the impressiveness of their body of work. If there's anything I can do to assist in the future development of this mod (including sponsoring its development via KoFi, Patreon, etc.), please let me know.
Also thank you to @Treetrain1 (whose review, testing and feedback I would greatly appreciate!) for all the work on getting the mod to 1.19.3 (especially the datagen gradle task!)