paulfitz / daff

align and compare tables
https://paulfitz.github.io/daff
MIT License
790 stars 68 forks source link

Publish a new package to npm #175

Closed MPeli closed 2 years ago

MPeli commented 2 years ago

Hi,

I noticed that fibers were updated to version 5 (d0c5237ed9d8a42b06d71037b862447360082823) but a new package has not been released. @paulfitz, could you release it please?

Thank you, Martin.

paulfitz commented 2 years ago

Done now I think. Let me know if there's a problem. I feel guilty for the fibers dependency, there isn't much need for it, I should remove it.

MPeli commented 2 years ago

Thank you, the update of fibers helped, I managed to install it. I am trying to import daff into an angular project. Unfortunately, it seems that the daff.js is not a js module. Would it be possible to update it? Thank you.

MPeli commented 2 years ago

I found some Haxe modules which might be helpful.

https://haxe.org/manual/target-javascript-es6.html

MPeli commented 2 years ago

I also noticed that node_modules/daff/bin/daff.js contains a comment #!/usr/bin/env node on the first line.

I managed to make the daff work.

  1. Remove the comment
  2. Add daff.js into angular.json
    "scripts": [
    "node_modules/daff/bin/daff.js"
    ]
  3. Add declare var daff: any; into your component

Would it be possible for you to remove the hashtag comment please?