search

paulfitz / daff

align and compare tables
https://paulfitz.github.io/daff
MIT License
790 stars 68 forks source link

Set the version in the POM file before building the package #194

Closed mardukbp closed 11 months ago

mardukbp commented 11 months ago

The project version in the current POM file contains a placeholder that is replaced during Maven's execution. However, Maven repositories read the version from the POM file.

This PR reads the version from package.json and updates the version in the POM file. Afterwards the build process and the deployment can proceed as usual.

The instructions for deploying, found in RELEASE.md, were correspondingly updated.

paulfitz commented 11 months ago

I tried another release. Needed to mint a new version, there is a github release that happens too that complicates things (if there were a way to disable that it would be great).

mardukbp commented 11 months ago

A-wesome! Thanks a lot @paulfitz! I just built a small project with it.

Yes, the GitHub releases can be avoided. Take a look at the documentation of JReleaser. Instead of full-release I think you would want to execute deploy and upload.