search

paulfitz / daff

align and compare tables
https://paulfitz.github.io/daff
MIT License
801 stars 67 forks source link

Diff corrupt if 2 columns are equal #61

Open wollgarten opened 8 years ago

wollgarten commented 8 years ago

Hello, your daff tool is very comfortable - great work - but i have a problem with it:

Assume the following file: A,B,C a,b,c

Change the file to: A,B,C,C a,b,c,c

.. then "git diff" shows that the last column has been removed.

paulfitz commented 8 years ago

Thanks for reporting that @wollgarten. The diff in this case is definitely unhelpful. daff does not currently have a way to deal gracefully with columns that have the same name. Will look at adding a way.

bluunk commented 7 years ago

Hi @paulfitz , also thanks from my side for working on daff!

I am currently experiencing a related issue. I am trying to use daff on csv files with more than one header row, e.g.:

1: category1, category1, category2, category2 2: subcat1, subcat2, subcat1, subcat2 3: data, data, data, data, data (...)

To daff, this must look as if all column names exist two or three times. In my case, the effect is different from what @wollgarten observed

: Daff does not detect any changes. That is, the output of daff diff a.csv b.csv is just empty. When I run daff diff a.csv b.csv --all, the data of a.csv is displayed, without any changes.

Daff only works when I delete columns until only very few columns with duplicate names are left.

Attached two example files and a diff html.

example csv.zip

//edit: In the example files I set all values to 1. However, the same bug appears when all cells hold unique values.