search

paulfloyd / freebsd_valgrind

Git repo used to Upstream the FreeBSD Port of Valgrind
GNU General Public License v2.0
15 stars 4 forks source link

memcheck/tests/threadname (and xml version) fail on FreeBSD 12.2 #147

Closed paulfloyd closed 3 years ago

paulfloyd commented 3 years ago

These tests didn't build prior to 12.2 since the HAVE_PTHREAD_SETNAME_NP feature test did not pass.

Now we get

paulf> less threadname.stderr.diff 
--- threadname.stderr.exp       2020-05-08 13:24:22.730037000 +0200
+++ threadname.stderr.out       2020-11-16 11:27:20.813063000 +0100
@@ -17,7 +17,7 @@
    by 0x........: child_fn_0 (threadname.c:67)
    ...

-Thread 3 try1:
+Thread 3:
 Invalid write of size 1
    at 0x........: bad_things (threadname.c:21)
    by 0x........: child_fn_1 (threadname.c:51)
@@ -29,7 +29,7 @@
    ...

 I am in child_fn_1
-Thread 4 012345678901234:
+Thread 4:
 Invalid write of size 1
    at 0x........: bad_things (threadname.c:21)
    by 0x........: child_fn_2 (threadname.c:35)

where the diffs are were the name should be printed.

paulfloyd commented 3 years ago

Fixed with

To github.com:paulfloyd/freebsd_valgrind.git 7f6d66a5f..27722f84f freebsd -> freebsd