search

paulfloyd / freebsd_valgrind

Git repo used to Upstream the FreeBSD Port of Valgrind
GNU General Public License v2.0
15 stars 4 forks source link

pdfork_pdkill fails on 13.2 p2 amd64 #201

Closed paulfloyd closed 11 months ago

paulfloyd commented 11 months ago

Small change

--- pdfork_pdkill.stderr.exp    2022-01-17 18:13:47.649545000 +0100
+++ pdfork_pdkill.stderr.out    2023-08-19 08:35:53.095038000 +0200
@@ -1,4 +1,4 @@
-parent: kill fd 3
+parent: kill fd 5
 Syscall param pdfork(fdp) points to unaddressable byte(s)
    ...
    by 0x........: main (pdfork_pdkill.c:88)

On 13.2-p2 just before the printf lsof says the open files are

paulf> lsof -p 29812                              
lsof: WARNING: compiled for FreeBSD release 13.1-RELEASE-p7; this is 13.2-RELEASE-p2.
COMMAND     PID  USER   FD      TYPE                DEVICE SIZE/OFF    NODE NAME
pdfork_pd 29812 paulf  txt      VREG 1837934384,1768873499    19312 1107189 /usr/home/paulf/scratch/valgrind/memcheck/tests/freebsd/pdfork_pdkill (zroot/usr/home)
pdfork_pd 29812 paulf ctty      VCHR                 0,167      0t0     167 /dev/pts/2 (devfs)
pdfork_pd 29812 paulf  cwd      VDIR 1837934384,1768873499      242  207692 /usr/home/paulf/scratch/valgrind/memcheck/tests/freebsd (zroot/usr/home)
pdfork_pd 29812 paulf  rtd      VDIR   42634684,1100013148       28       4 / (zroot/ROOT/default)
pdfork_pd 29812 paulf    0u     VCHR                 0,167  0t68882     167 /dev/pts/2 (devfs)
pdfork_pd 29812 paulf    1u     VCHR                 0,167  0t68882     167 /dev/pts/2 (devfs)
pdfork_pd 29812 paulf    2u     VCHR                 0,167  0t68882     167 /dev/pts/2 (devfs)
pdfork_pd 29812 paulf    3u  PROCDSC                                        pid=29813

and 13.1

paulf@freebsd:~ $ lsof -p 868
lsof: WARNING: compiled for FreeBSD release 13.2-RELEASE-p2; this is 13.1-RELEASE-p9.
lsof: WARNING -- reading lockf list failed: No such file or directory
COMMAND   PID  USER   FD      TYPE DEVICE SIZE/OFF   NODE NAME
pdfork_pd 868 paulf  txt      VREG   0,90    19128 574785 /usr/home/paulf/valgrind/memcheck/tests/freebsd/pdfork_pdkill (/dev/ada0s1a)
pdfork_pd 868 paulf ctty      VCHR   0,93      0t0     93 /dev/pts/1 (devfs)
pdfork_pd 868 paulf  cwd      VDIR   0,90     6144 568725 /usr/home/paulf/valgrind/memcheck/tests/freebsd (/dev/ada0s1a)
pdfork_pd 868 paulf  rtd      VDIR   0,90     1024      2 / (/dev/ada0s1a)
pdfork_pd 868 paulf    0u     VCHR   0,93  0t49620     93 /dev/pts/1 (devfs)
pdfork_pd 868 paulf    1u     VCHR   0,93  0t49620     93 /dev/pts/1 (devfs)
pdfork_pd 868 paulf    2u     VCHR   0,93  0t49620     93 /dev/pts/1 (devfs)
pdfork_pd 868 paulf    3u  PROCDSC                        pid=869

Also fails with latest 13.1 kernel patch

paulf@freebsd:~ $ lsof -p 14421
lsof: WARNING: compiled for FreeBSD release 12.4-RELEASE-p4; this is 12.3-RELEASE-p6.
COMMAND     PID  USER   FD      TYPE DEVICE  SIZE/OFF   NODE NAME
pdfork_pd 14421 paulf  txt      VREG   0,89     18704 108620 /usr/home/paulf/valgrind/memcheck/tests/freebsd/pdfork_pdkill (/dev/ada0s1a)
pdfork_pd 14421 paulf ctty      VCHR   0,91       0t0     91 /dev/pts/0 (devfs)
pdfork_pd 14421 paulf  cwd      VDIR   0,89      6144 107635 /usr/home/paulf/valgrind/memcheck/tests/freebsd (/dev/ada0s1a)
pdfork_pd 14421 paulf  rtd      VDIR   0,89      1024      2 / (/dev/ada0s1a)
pdfork_pd 14421 paulf    0u     VCHR   0,91 0t1139161     91 /dev/pts/0 (devfs)
pdfork_pd 14421 paulf    1u     VCHR   0,91 0t1139161     91 /dev/pts/0 (devfs)
pdfork_pd 14421 paulf    2u     VCHR   0,91 0t1139161     91 /dev/pts/0 (devfs)
pdfork_pd 14421 paulf    3u  PROCDSC                         pid=14422

hmm

paulfloyd commented 11 months ago

In the end this was a regression (leaked fd and memory) intruduced with delayed loading of debuginfo.