search

paulgalow / fileshelter-docker

A Docker workflow for running FileShelter
Apache License 2.0
12 stars 3 forks source link

make updating fileshelter simpler by building the image locally #4

Closed renefritze closed 4 years ago

renefritze commented 4 years ago

This could make users of the compose setup less dependent on your docker.io/paulgalow/fileshelter being updated regularly.

paulgalow commented 4 years ago

I think this is a great idea. This would automate future deployments, provide more transparency (building a local container rather than pulling down a prebuilt one) and make updates simpler, as you mentioned. The only downside I'm seeing is the increased initial build time especially for first time users.

renefritze commented 4 years ago

True, the initial build would take some time. One idea to combine both setups would be to just have the local Dockerfile source your image from dockerhub as base and basically just have an appropriate user switch + apt update && apt install -y fileshelter.

Me in your place, I wouldn't mind the first time build cost if by paying that I would not have to maintain an image source separate from the compose setup.

paulgalow commented 4 years ago

Just reviewed this PR again. I think you are right. Building the image locally is a very elegant way to keep everything up to date. Thanks for suggesting this.