Closed mikebronner closed 11 years ago
mikebronner
commented
11 years ago Sorry for the massive amounts of reverts ... this was my first pull request, so I wanted to do it right and make a branch on my side for the change, so I can make other branches for other changes, instead of making the changes to the master.
paulgibbs
commented
11 years ago Was this intentionally closed?
mikebronner
commented
11 years ago Initially closed because I wanted to integrate this code directly into your existing functions, but changed my mind. Splitting this out into separate functions allows for more customization down the road.
paulgibbs
commented
11 years ago Can you squash those reverted commits together; or close this pull request, create a new branch, make a single commit, then pull from that?
mikebronner
commented
11 years ago I tried but couldn't figure out how … I'll keep looking.
~Mike
On Apr 16, 2013, at 9:32 AM, Paul Gibbs notifications@github.com wrote:
Can you squash those reverted commits together; or close this pull request, create a new branch, make a single commit, then pull from that?
— Reply to this email directly or view it on GitHub.
mikebronner
commented
11 years ago Too many screwy reverts. Resetting master fork to get rid of reverts and will resubmit pull request from branch.
I have added the code necessary to show thumbnails in the admin page. Below is a preview of what it might look like. Disregard the Category columns as that is not part of this functionality.
The thumbnail header is not sortable at this time -- I didn't think sorting by image made sense.
Added comments in two places where changes can be made, theoretically in a Settings page if a UI were to be added in the future. One for column placement (default is 2nd), other for header title (default is Badge).
Thumbnail size is set to 39px to fit in current row heigh, but can be made larger without any problem.