search

paulgibbs / buddypress-xcf

ignore this
0 stars 0 forks source link

Code standards - PSR-2 for WP #2

Open paulgibbs opened 8 years ago

paulgibbs commented 8 years ago

It looks like the new files are written to PSR-2, which is nice, but for BP core, we need them to match the WordPress code standards.

donmik commented 8 years ago

I've created a new branch for this. I'm not sure if I've understand all the code standars or miss anyone. I've installed php code sniffer with Wordpress Code Standars and tried to solve all the errors I could. Can you check class-bp-xprofile-field-type-confirmation.php to see if it's what you are talking about.

https://github.com/paulgibbs/buddypress-xcf/tree/wp-standards

paulgibbs commented 8 years ago

that looks pretty good -- I think that's right! 👍

donmik commented 8 years ago

Latest commit inside wp-standards branch solves all issues I've found. Can we merge?

paulgibbs commented 8 years ago

Sure

Paul Gibbs

On 22 Aug 2016, at 17:06, Miguel notifications@github.com wrote:

Latest commit inside wp-standards branch solves all issues I've found. Can we merge?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

paulgibbs commented 8 years ago

I am busy until Thursday evening, but will look then and see what we should do next. Thanks for your effort so far! :)