search

paulgoetze / weka-jruby

Machine Learning & Data Mining with JRuby
MIT License
65 stars 8 forks source link

Feature: allow passing hash to Instances#add_instance #16

Closed kcning closed 7 years ago

kcning commented 7 years ago

At the moment adding instance can only be done by providing an Instance or an array of attribute values sorted according to the attribute order. It would be nice to be able to pass a hash of attribute values so we don't have to care about the order.

paulgoetze commented 7 years ago

@kcning Another small thing: could you stash your commits or make sure they describe the changes properly? Commit messages like tidy up or bug fix are not too descriptive if you want to know what has changed (also consider rebasing if you pull changes from the upstream branch) Thank you! :)

kcning commented 7 years ago

Thanks for the quick review! I fixed the problems. Please let me know if more should be changed.

paulgoetze commented 7 years ago

@kcning Hm, looks like somehow three of my earlier commits sneaked into your changes (now with other hashes).

Removing them and rebasing on top of your develop should clean this up:

# for each of the three commits:
git rebase --onto commit-id^ commit-id

# then rebase on your develop branch:
git rebase develop

(Maybe make a backup of you branch before, in case something goes wrong)

kcning commented 7 years ago

oke, it's done!

paulgoetze commented 7 years ago

Thanks @kcning for your patience with all my nitpicking on changes and codestyle! ;) Looks great.