search

paulgp / binscattr

9 stars 1 forks source link

ggplot2 Extension #6

Open vikjam opened 6 years ago

vikjam commented 6 years ago

Not sure if it'd be helpful, but have you looked at implementing this as a ggplot2 extension?

paulgp commented 6 years ago

Yes, this could work -- we're effectively using stat_summary and geom_smooth anyway. The only complicated part is doing the residualization in the background.

On Thu, Mar 15, 2018 at 11:34 PM, vikjam notifications@github.com wrote:

Not sure if it'd be helpful, but have you looked at implementing this as a ggplot2 extension https://cran.r-project.org/web/packages/ggplot2/vignettes/extending-ggplot2.html ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/paulgp/binscattr/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AEcxllniFYuc6ZZiyMPr7sj0E3xBNzKdks5tezKsgaJpZM4StM0Z .

vikjam commented 6 years ago

Cool, I'll take a closer look at this and put a pull request together (if that'd be helpful).

paulgp commented 6 years ago

That would be great! On Fri, Mar 16, 2018 at 11:56 AM vikjam notifications@github.com wrote:

Cool, I'll take a closer look at this and put a pull request together (if that'd be helpful).

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/paulgp/binscattr/issues/6#issuecomment-373758620, or mute the thread https://github.com/notifications/unsubscribe-auth/AEcxlpGCRR9jhK9fP2ahZFQ32WuFNP6Cks5te-CpgaJpZM4StM0Z .