Refactorings - Githubissues

paulgreg / UniquePasswordBuilder

A bookmarklet to generate strong password per site

https://paulgreg.me/UniquePasswordBuilder/

MIT License

8 stars 4 forks source link

Refactorings #15

Closed pmiossec closed 6 years ago

pmiossec commented 6 years ago

(easier to review commit by commit)

make availableCharsa string
pass algorithm parameters as an object (make more sense and is more adaptable for the future)
reenable logs (when sensitive data are not hidden)

paulgreg commented 6 years ago

QUnit tests aren’t passing : TypeError: upb.makeHashHumanReadablePassword is not a function.

I’m not understanding the renaming of makeHashHumanReadable into makeHashHumanReadablePassword or makeHashHumanReadablePin. Ideally, it would be better to make the renaming into another commit (or at least fix unit test).

pmiossec commented 6 years ago

Sorry but the renaming was not intended to be in this commit. So I removed it and it fixes everything...