search

paulh-rnd / TabbedBoxMaker

Inkscape tabbed box generator plugin - quickly design complex "finger jointed" boxes
GNU General Public License v2.0
200 stars 47 forks source link

minor enhanchement #12

Open MHz000 opened 7 years ago

MHz000 commented 7 years ago

Thanks a lot paulh-rnd for doing this great job!

May I suggest two minor enhancements:

  1. there might be conditions where one just need the box without the dividers or the other way around as one just need the dividers to fit an existing box. Two checkboxes will do the trick.
  2. in either case it might be avantageous to declare a different material thickness for the dividers - this affects the "fitting" slots of the dividers

Both proposals aren't absuloutly necessary as you can do it always in seperate jobs however I belive they are worth to have a look at for the sake simplicity

Thanks again

paulh-rnd commented 7 years ago

Great suggestions! I started making a few improvements a few months ago but I've just been too busy to complete them. Besides that, the code is already pretty messy and adding too many more features is just going to contribute to debugging complexity and ongoing maintenance - I'd love to spend some time learning Python and cleaning up the code, but it's not likely to happen this year sadly.

Having said that, the first one is a relatively simple modification to make. I'll keep this on the cards anyway and might get a chance to add it. The second one will be a bit more involved: you may have noticed that the dividers are really just extra copies of the box sides with a cutout for slotting them together, and the holes cut into the box sides are just a re-wiring of the "finger" edge on that same face - so this would need to be modified quite a bit.

Thanks again!

paulh-rnd commented 7 years ago

Oh hey, will you look at that. By chance I happened to glance at forks of the code straight after answering your question and look what I found!

Looks like that change might do the trick. I don't have time to do a merge right now or test, but if you want to give it a go and send me a pull request if it works for you, that would be awesome.... :)

If not, I might have a bit of time over the next couple of weeks.

MHz000 commented 7 years ago

Hi paulh-rnd, thank you for the positive reply. My first suggestion - separate the box making from the divider making - will convenient solve all requirements. One can construct the box with inner dimension and on a separat run the dividers with outer dimension specified and a different material size. Voilà thats it - as long as you don't need the keepers. Thank you for direct me to deepinthewoods contribution. However I don't know how to deal with (shame on me ... download, merge, ... no idea! ) Yes I'm a newbee and english is not my strength :-( Thank you again and may be you will have a look at my first "opus" ... with the help of a friend! ​

2017-03-20 11:12 GMT+01:00 paulh-rnd notifications@github.com:

Oh hey, will you look at that. By chance I happened to glance at forks of the code straight after answering your question and look what I found https://github.com/deepinthewoods/TabbedBoxMaker/commit/416fe8baa85b65db307b35e6029b0ab3d9a0894f !

Looks like that change might do the trick. I don't have time to do a merge right now or test, but if you want to give it a go and send me a pull request if it works for you, that would be awesome.... :)

If not, I might have a bit of time over the next couple of weeks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/paulh-rnd/TabbedBoxMaker/issues/12#issuecomment-287719027, or mute the thread https://github.com/notifications/unsubscribe-auth/AHmpGmUEYGbFMA0pG85dGdrLtEI2ygHwks5rnlEjgaJpZM4MgwB- .

MHz000 commented 7 years ago

oh I forgot my question: the number of dividers is limited to 10. Can this be lifted? Best regards

mshorter commented 7 years ago

Thanks for all the work it looks great. I'd like to throw out a couple of other suggestions. I do realize they maybe too complicated to add and make things nice though.

  1. I'd like to be able to define where I want the dividers. Right now it just divides into equal parts. In my case I also want one side open but dividers in the other side so being able to do half length dividers would be awesome (this is where things get hard).
  2. I'd like to see different box lids. Right now it looks like the only option is finger slots, but a lid that slides in, hinged lid, etc., would be a nice feature as well. Thanks!
paulh-rnd commented 4 years ago

@mshorter thanks for the suggestions and sorry for not replying sooner - not sure why I didn't see your comment before. I like (1), and I've added it to a new issue. (2) is a lot harder and not really where I wanted to take this project yet, but they are great suggestions. IF you have any more suggestions, please feel free to add a new enhancement request (rather than comment on an existing one like this - your ideas may get lost!)

Thanks again for supporting TabbedBoxMaker!