search

paulh-rnd / TabbedBoxMaker

Inkscape tabbed box generator plugin - quickly design complex "finger jointed" boxes
GNU General Public License v2.0
200 stars 47 forks source link

Updating variable names, indent size (2 to 4 spaces) and such for PEP… #53

Closed permalost closed 7 months ago

permalost commented 1 year ago

…8. Leaving long lines and single/double character variablesa

paulh-rnd commented 7 months ago

Sorry for the long delays in getting to this. I've reviewed this PR and appreciate the work you put in, however I'm hesitant to make such wholesale changes across the code when the code has been forked 41 times. Yeah, it's not even close to being PEP 8 compliant, but wholesale renaming functions and variables in open source for no other reason than compliance with PEP 8 doesn't sit well with me. Ultimately the whole thing really needs a rewrite, and if that ever happens I'll be sure to write it much more cleanly.

It wasn't written by me originally, and I've just continued the style in my modifications. If I'd known this would become as popular as it is I would have probably started my fork with a rewrite, but I really only started this project to scratch my own itch, and decided to share it.