search

paulh-rnd / TabbedBoxMaker

Inkscape tabbed box generator plugin - quickly design complex "finger jointed" boxes
GNU General Public License v2.0
200 stars 47 forks source link

Three bug fixes #59

Closed mausmaux closed 7 months ago

mausmaux commented 8 months ago

(1) There is a bug with unit conversion for the kerf parameter. It's applied to already converted units which leads to cm units having kerf 10x too large and inch units have kerf 25.4 times too large. This probably also explains #52.

(2) Dimples lack unit conversion, so are always applied in native units, which is mm. I assume that was not intentional.

(3) Boxes which have omitted sides are incorrectly drawn when using the rotationally symmetric mode. The last point on the untabbed sides is calculated as if the tabs were present. This affects both the box sides and any internal dividers similarly.

paulh-rnd commented 7 months ago

Thanks very much for your PR and apologies on taking so long to get around to testing this! The changes look good, I've merged them and will credit you in the comments in a version bump later today.