search

paulhamsh / SparkMIDI

Midi control capability for the Spark 40 Amp
Apache License 2.0
10 stars 4 forks source link

enchancement: Preset checksum validating #6

Open copych opened 2 years ago

copych commented 2 years ago

May I ask that some time in the future the library would check the downloaded presets for consistancy based on the checksum as PG implemented? I ask because several times I faced issues with visually incomplete data, though no warnings or method fails rised.

paulhamsh commented 2 years ago

Can you give an example of what you mean? To do a checksum on the preset structure? So a check_preset(SparkPreset xx) sort of thing? But the compiler should issue a warning about a bad structure?

On 25 Apr 2022, at 07:51, copych @.***> wrote:

 May I ask that some time in the future the library would check the downloaded presets for consistancy based on the checksum as PG implemented? I ask because several times I faced issues with visually incomplete data, though no warnings or method fails rised.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

copych commented 2 years ago

I am sorry, Paul, my fault. I've found that there's such function already in your code.