search

paulhibbing / AGread

Read Accelerometer Files from ActiGraph Accelerometers
Other
15 stars 4 forks source link

Warning logic for ACTIVITY #28

Closed muschellij2 closed 3 years ago

muschellij2 commented 3 years ago

https://github.com/paulhibbing/AGread/compare/master...muschellij2:master#diff-8a289ca0262cfd5e91c7936b2605af82R71 changes warning for #27. Not necessary, but think it makes more sense logically. The other stuff is whitespace changs.

paulhibbing commented 3 years ago

Looks like this was both a logic issue, and a step I left out when pulling ACTIVITY packets together. I took an approach in #29 that I think is a little more concise. See specifically this commit and let me know your thoughts.

As for the other commits in #29, my inexperience is probably showing by opening a separate PR and manually implementing some of the new features you've already put in this one. Seems like that's neither efficient nor organized... But I think it will result in a cleaner history if we decide to incorporate #29 in lieu of #28.

Thanks as always for your help.