search

paulhitz / DnB-REST-Client

Custom REST Client for D&B (Dun & Bradstreet) services.
https://github.com/paulhitz/DnB-REST-Client
MIT License
5 stars 5 forks source link

Use Interceptor for Authentication #14

Closed paulhitz closed 9 years ago

paulhitz commented 9 years ago

(See 'interceptor' branch)

Using an Interceptor for Authentication will make the main app more cohesive and easier to maintain.

However, there are knock-on effects to consider...

1) We still need to update the app with the authentication token used. Should we now get it from the response? Or perhaps the Mediator? 2) Need to still be able to display authentication errors in UI. 3) Need to cancel service request if authentication fails. 4) Need a way of updating the progress bar. Should we still even use it when authenticating? 5) Consider adding the Authentication service to the list of supported services. Obviously a request to this service shouldn't be authenticated.

Given the impact, is it worth continuing with?

paulhitz commented 9 years ago

Closing this. Not implemented. The cons outweigh the pros.