search

pauliacomi / pyGAPS

A framework for processing adsorption data and isotherm fitting
MIT License
63 stars 24 forks source link

Documentation: Modelling in pyGAPS #29

Closed sblanky closed 2 years ago

sblanky commented 2 years ago

In the list of models, all are given in lower case. From my implementation, they don't actually work like that Not all models provided correspond to internal models

It does work if you use the appropriate case though i.e. 'Langmuir', 'DSLangmuir', 'GAB'.

Documentation could be updated to reflect this.

Thanks, Scott

pauliacomi commented 2 years ago

Thanks for pointing it out. Maybe it would be best if the case shouldn't matter, so you could pass any of Langmuir, LANGMUIR or LaNgMuIr. How does that sound? -pi

sblanky commented 2 years ago

That does sound like the best option!

pauliacomi commented 2 years ago

Should be fixed by https://github.com/pauliacomi/pyGAPS/commit/cc869bf2c1a8a8409dbcd179dcdcf3c967dd44c8