search

pauliacomi / pyGAPS

A framework for processing adsorption data and isotherm fitting
MIT License
63 stars 24 forks source link

Circular import on pip install #48

Closed sblanky closed 1 year ago

sblanky commented 1 year ago

When I attempt to install a new version (after my edits) of pyGAPS,

pip install ~/pyGAPS/

the modules in parsing .csv and .json throw an error such as; AttributeError: partially initialized module 'json' has no attribute 'loads' (most likely due to a circular import)

or

ImportError: cannot import name 'QUOTE_NONNUMERIC' from partially initialized module 'csv' (most likely due to a circular import) (/home/pcxtsbl/pyGAPS/src/pygaps/parsing/csv.py)

I think this is because they have the same external modules .

Changing names to, for example .csv_ fixes this issue.

pauliacomi commented 1 year ago

I have not been able to replicate this on any system.

Any chance you can verify this in a fresh environment?

sblanky commented 1 year ago

Tried in a fresh environment, and can't get it to make this error. It may have been to do with the specific changes I made at some point, which I no longer need.

Sorry! Closing this.