search

paulintrognon / paulintrognon.fr

Paulin Trognon Personal website
https://paulintrognon.fr
6 stars 0 forks source link

[blog/post/typescript-prettier-eslint-next-js] Missing "plugin:react-hooks/recommended" in eslint config? #5

Closed thomasmery closed 3 years ago

thomasmery commented 4 years ago

Hi Paulin,

thanks a lot for the article :)

I was wondering if the "plugin:react-hooks/recommended" was missing in the eslint config

it seems I have to add it to get the desired reporting on bad hooks practices

Merci !

thomasmery commented 4 years ago

also this: https://github.com/vercel/next.js/tree/canary/examples/with-typescript-eslint-jest

has been added to the Next repo recently I think

hyalen commented 4 years ago

Hey Paulin, thanks for the article!!

It helped me a lot to configure the basics for my Next project with Typescript support =D

paulintrognon commented 3 years ago

I was wondering if the "plugin:react-hooks/recommended" was missing in the eslint config

True! I have added it, thanks!

also this: https://github.com/vercel/next.js/tree/canary/examples/with-typescript-eslint-jest has been added to the Next repo recently I think

Yes, that's right. My approach is a bit different though, I listed the main differences here: https://github.com/paulintrognon/next-typescript#what-is-the-difference-with-official-with-typescript-eslint-jest

Thank you for the feedback!

paulintrognon commented 3 years ago

Fixed in 412e7644b09cdbc65f567349c81f806304f8e771