Fix code example - Githubissues

paulirish / automated-chrome-profiling

Node.js recipes for automating javascript profiling in Chrome

https://github.com/paulirish/automated-chrome-profiling#readme

863 stars 72 forks source link

Fix code example #1

Closed cyrus-and closed 9 years ago

cyrus-and commented 9 years ago

fix RDB method calls
use console.profile/profileEnd instead of Profiler.start/stop RDB methods
remove the timeout
fix link to CPUProfile object
close the connection after writing the file
add async example
trim trailing spaces

paulirish commented 9 years ago

Epic PR. Thank you so much!

Part of me likes to continue to use the Profiler.start()/stop its also nice to handle it straight-up in client-side.

you really made this look professional. thank you sir.

vladikoff commented 9 years ago

Great work @cyrus-and! :gift:

cyrus-and commented 9 years ago

Thanks!

No problem @paulirish, feel free to revert that, I used console.profile/profileEnd because I couldn't figure out how to otherwise remove the timeout. It could be nice to refactor this script into a proper app which possibly support both methods.