search

paulirish / git-open

Type `git open` to open the GitHub page or website for a repository in your browser.
MIT License
3.29k stars 247 forks source link

Fix issue #121 - incompatability with bash < 4 #122

Closed derimagia closed 6 years ago

derimagia commented 6 years ago

Should fix issue #121. @4U6U57 if you have a minute can you confirm this is good?

Let's add testing for bash < 4 when we can

4U6U57 commented 6 years ago

Yeah, that's obviously equivalent, looks good.

Looks like we also need to fix ci in general, failing on the install stage with shellcheck. This is a pretty serious regression, so I'm okay merging this first and filling a separate issue.

derimagia commented 6 years ago

👍

4U6U57 commented 6 years ago

Aw shoot, should have tested this. The replacement is backwards, should be tr '[:lower:]' '[:upper:]'.

derimagia commented 6 years ago

Too bad the CI is down, ha - can you verify it in #123 - I don't have the ssh config functionality set up at the moment