search

paulirish / git-open

Type `git open` to open the GitHub page or website for a repository in your browser.
MIT License
3.31k stars 247 forks source link

Fish shell compatibility #136

Closed MartinDelille closed 5 years ago

MartinDelille commented 5 years ago

I would like to use git-open with Fish but it doesn't worked.

I installed it with fisher plugin manager.

Do you think it could be possible to add git-open support to Fish?

paulirish commented 5 years ago

I use fish shell myself and have no problems. I install it via npm, so I guess the problem is the fisher package?

MartinDelille commented 5 years ago

I don't know what happen but I uninstalled it and reinstalled it: it works now.

MartinDelille commented 5 years ago

No it doesn't work. Thing we need to have a file like conf.d/git-open.fish that would add git-open to the path.

MartinDelille commented 5 years ago

I tried adding my local git-open clone to the path and it works!

I just have to figure out how to add it in a fish plugin.

paulirish commented 5 years ago

yup technically all that needs to happen is that git-open needs to be in the path.

the git binary does the magic of mapping that to git open

MartinDelille commented 5 years ago

The brew do perfectly the job so I keep with that.

You can close the issue if you want because I won't provide fix for it in the end.