search

paulirish / git-open

Type `git open` to open the GitHub page or website for a repository in your browser.
MIT License
3.29k stars 247 forks source link

Remove unused code and fix double-negation #153

Closed sowmiyamuthuraman closed 2 years ago

sowmiyamuthuraman commented 4 years ago

Co-authored-by: Jayashree jayashree.kammu@gmail.com

We are using your tool for a long period of time. We are interested to contribute to the tool. While we are going through the code we think we found an unused code.

exec &>/dev/null - we are redirecting the outstream and errstream to null but we are not printing anything after this line. So we think we can remove this line. What do you think?

wingleung commented 4 years ago

Can we merge this one? It'll fix the travis builds

derimagia commented 4 years ago

@paulirish do you know if this code is needed anymore? https://github.com/paulirish/git-open/pull/153/commits/c01506eaca7a8c25534fa727af1c2f8e2d0f9a20

derimagia commented 4 years ago

If we split these into 2 PRs (https://github.com/paulirish/git-open/pull/153/commits/c01506eaca7a8c25534fa727af1c2f8e2d0f9a20 and https://github.com/paulirish/git-open/pull/153/commits/f27d913de25047bf0403e283456471d9809ca838)

Looks like the latter one is the issue with the build and is straight forward enough to merge.