search

paulirish / git-open

Type `git open` to open the GitHub page or website for a repository in your browser.
MIT License
3.29k stars 247 forks source link

Add suffix flag #154

Closed dineshba closed 4 years ago

dineshba commented 4 years ago

Co-authored-by: Sowmiya sowmiyamuthuraman@gmail.com

Fix for https://github.com/paulirish/git-open/issues/145

paulirish commented 4 years ago

👍 Seems well defined and clean. Any feedback from anyone else?

ffes commented 4 years ago

It makes it easier to go to pages that don't have their own implementation, but it becomes bulky to type. So I don't see myself using it a lot. But it doesn't bother me.

What if somebody wants to implement a --prs flag? Are we gonna reject that because it can be done with --suffix pulls?

One thing I really miss is the description of the flag in the man page!

dineshba commented 4 years ago

Hi @paulirish/@ffes Thanks for the inputs.

What if somebody wants to implement a --prs flag? I think we accept those PRs as flags like --prs will reduce lot of typing.

As you mention it makes it easier to go to pages that don't have their own implementation, its a generic solution (for any flags). I feel we can have both the things.

One thing I really miss is the description of the flag in the man page! We have updated in README.md. Do we have someother place to update? If so, please point me to that. Thanks

ffes commented 4 years ago

Do we have someother place to update?

The source of the man-page is git-open.1.md

dineshba commented 4 years ago

@ffes Thanks. Updated the git-open.1.md and amended to the same commit.

ffes commented 4 years ago

Looks good to me

dineshba commented 4 years ago

@paulirish and @ffes Can we merge this ?