search

paulirish / lite-youtube-embed

A faster youtube embed.
https://paulirish.github.io/lite-youtube-embed/
Other
5.6k stars 259 forks source link

Multiple mount #143

Closed michalmatuska closed 4 months ago

michalmatuska commented 1 year ago

Hi all, I found out big issue. WebComponent doesn't take care about unmout method but what's worst are unwanted multiply mounts. Simple DOM operation like appendChild start connected callback again. Example here https://codepen.io/superkoders/pen/MWqJjQv Result Liteyoutube double init test 2023-02-28 10-16-34

paulirish commented 9 months ago

This was fixed in v0.1.2 which was 3 years ago...

To @michalmatuska and the folks +1'ing this issue.. do you know why you're using such old versions of this project?

michalmatuska commented 9 months ago

Hmm I would like to know it but is too long time now. I am not sure what project it was. Sorry. It could be some issue with NPM or my fault.