Closed santoshjoseph99 closed 6 years ago
@denar90 sounds good. I'll update.
@denar90 I'm not sure what you mean by the land on the docs?
Also I'm seeing a failure in CI...should I change the signature of the log function to be:
log(msg: any, ...args: any[]) {
if(Logger.options.showOutput){
console.log(msg, ...args);
}
}
?
Moving thread here,
lgtm 👍 one nitpick, can you update docs so we can land it?
@denar90 I'm not sure what you mean by the land on the docs? Also I'm seeing a failure in CI...should I change the signature of the log function to be:
log(msg: any, ...args: any[]) { if(Logger.options.showOutput){ console.log(msg, ...args); } }
?
Sorry, for the confusion. I meant that it will be nice if you can update
readme.md
about new flag. As result we can publish new version. And I'm ok with signature of the log function.
v3.3.0 published to npm 🎉
🆒
Related to https://github.com/paulirish/pwmetrics/issues/184
Test file: https://gist.github.com/santoshjoseph99/c796663002b03812cc197fe1f8bb8d38
Note:
logFunc
to check if the message is alog
or anerror
, since right now I'm just usingconsole.log
.logFunc
can be passed intoPWMetrics
as part of theoptions
, so it gives more control to the caller on how to show the messages.