search

paulirish / pwmetrics

Progressive web metrics at your fingertipz
Apache License 2.0
1.25k stars 74 forks source link

Update Lighthouse to version 6 #230

Closed Ge11ert closed 4 years ago

Ge11ert commented 4 years ago

So, this is actually just the basic update to a new Lighthouse version in order to get access to the new metrics.

I threw out Cumulative Layout Shift metric because it has only 5% impact to final score. And also First Meaningful Paint and First CPU Idle metrics have been deprecated in LH v6 update.

There are more new stuff in new LH version which should be (re)implemented, such as timing budgets and unused js. But I think it could be done in later PRs (not mine, just speaking in common)

Any thoughts/suggestions?

Ge11ert commented 4 years ago

Hmmm. Strange fact is that local run of npm run gulp-example ends successfully. And Travis has some kind of error from nowhere for that.

denar90 commented 4 years ago

Wow, that's awesome update. I'll try to go over it tomorrow. Thanks 👍

Ge11ert commented 4 years ago

@denar90 Hi! Any news about this PR?) It seems, no one is intending to interfere

denar90 commented 4 years ago

I'm happy to merge and release this one.

Also, we are going to deprecate pwmetrics in favor Lighthouse CI.

@Ge11ert any missed features in LHCI present in pwmetrics? whats your case?

Ge11ert commented 4 years ago

@denar90

@Ge11ert any missed features in LHCI present in pwmetrics? whats your case?

Actually, I chose pwmetrics some time ago for the ability of multiple runnings of lighthouse cli. This is what we'd wanted to get in our team's product project in order not to rely on single run. Because as we know there are some disturbances in lighthouse results from run to run due to network state and etc.

Speaking of LHCI, I think this is great to have some tool like that, but also I suppose, pwmetrics and LHCI serve different purposes. Using pwmetrics as easy as to install and run npm package. And if I get it right, LighHouse CI needs to be hosted somewhere with server configuration and other stuff. Which is way more complicated, to be honest.

This is not about refusing to read the docs and give it a try, no. I just barely have rights and possibilities to host LHCI on our company's staging servers for we have many teams and quite sophisticated infrastucture.

But thanks for reminding me about Lighthouse CI, definitely need to have a closer look, in case there are some options we can use easily.