search

paulirish / trace.cafe

easy webperf trace sharing
https://trace.cafe/
Apache License 2.0
115 stars 2 forks source link

trace.cafe doesn't use sourcemaps #8

Open esprehn opened 1 year ago

esprehn commented 1 year ago

If sourcemaps are available devtools will use it to rename functions in the traces, but when uploaded to trace.cafe the sourcemaps never work. It would be much easier to use trace.cafe if it loaded sourcemaps to show unminified names.

esprehn commented 1 year ago

Reading through the devtools frontend code it looks like sourcemaps come from the DebuggerModel: https://github.com/ChromeDevTools/devtools-frontend/blob/2314ddcbfed2456a0477b9cb5e17c48ed3ae7708/front_end/panels/timeline/PerformanceModel.ts#L113C3-L113C3

So devtools itself would need to change not trace cafe?

paulirish commented 1 year ago

In general, the behavior of the Perf panel in trace.cafe should be the same as if you open devtools on example.com and load a saved trace into that instance.

Everything is easy if you're viewing a freshly captured trace. But.. you can also trace a site, save it, open that same site in a new tab, load the trace there. And the location resolving (incl sourcemaps) shouldddddddd mostly work.

If not, we have some room to improve script matching etc.. But.. it's imperfect and we do risk matching against the wrong stuff. cc @and-oli who worked on location resolution.