search

paulirish / w3fools

https://www.w3fools.com/
152 stars 42 forks source link

Misleading tips for the dialog-Element at w3schools #52

Closed RaoulSchaffranek closed 11 years ago

RaoulSchaffranek commented 11 years ago

Hi guys, i didn't know where to report issues from w3schools, so please refer me to another point, if this is the wrong repository for such reports.

Okay w3schools is saying that dialog-Elements should be children of td- or th-elements, which is wrong. dialog-elements can be used in each context, where floating-content is expected, thus includes but not limits to td- and th-elements. Also they are hiding the information, that dialogs can be opened through other opportunities than the open-attribute as described here and demonstrated in an example here.

Garbee commented 11 years ago

Well, the WhatWG interpretation says "Where flow content is expected. As a child of a dt element. As a child of a th element. "

Although, if you believe there is an error in W3Schools content you may use the "Report Error" link in their footer to inform them.

RaoulSchaffranek commented 11 years ago

But this doesn't mean a restriction to those elements. To be honest i don't really know the purpose for explicit listing of those elements, since dt and th expect floating-content either way.

By the way, i said td-element in my first comment, when dt was actually meant.

However i will follow your recommendation and report this to w3schools.

Garbee commented 11 years ago

I'd assume W3Schools used a table in the demo since that is pointed out in the spec as a use-case. Their tip is wrong though saying it "should be a child" since it doesn't have to be. That can be mis-leading.

But, the demo itself is perfectly fine as a demo.

Also on the note of "hiding" information. I don't really think they are hiding anything. They just don't cover the specification in that detail. Honestly, what they have is fine aside of the the "should be a child" part. So simply file a report with them and hopefully they will fix that section of the page.

As per the current discussion of Issue #50 we are not going to continue maintaining a list of every little issue with their documentation (still needs updating on the site which I am working on to remove.)