paulirotta / Tantalum

Tantalum Cross Platform Library
12 stars 6 forks source link

Constructor with default priority should be provided #45

Closed jnynas closed 11 years ago

jnynas commented 11 years ago

For HttpGetter, JSONGetter etc

paulirotta commented 11 years ago

I did some small tuning and if I understand correctly, it should be fixed.

All Task objects must now have a priority set when they are created. Part of the one-true-path simplification that also means it is less likely have a Task which you forgot to set appropriate priority on and thus the app is not tuned

jnynas commented 11 years ago

I think I didn't make myself clear here. What I wanted to have is a constructor for each class without the priority parameter, where the priority is set to normal.

paulirotta commented 11 years ago

Perhaps offering a default priority constructor is more pretty. The downside of that (reason I pulled it from Task and everywhere else as a test) is by never thinking about the priority, you end up with a sub-optimal machine vs if you must think and assign a priority for each task. This is a matter of taste, but I cleaned up my current major project with noticeable improvements as a result. You could do the same with a global search, and it is arguably ugly / tedious to assign priorities.

Any other opinions / votes? Happy either way- it is Friday

paulirotta commented 11 years ago

Done