search

paulkinzett / toolbar

A tooltip style toolbar jQuery plugin
http://paulkinzett.github.com/toolbar/
MIT License
2.3k stars 321 forks source link

Toolbar cut off when button is too close to edge #1

Closed davidosomething closed 11 years ago

davidosomething commented 11 years ago

Screenshot here: http://screencast.com/t/Vo9pwhyB

k1ng440 commented 11 years ago

this issue must be fixed.

paulkinzett commented 11 years ago

If I add an option to choose if you want the toolbars anchor point to be either left, centred or right then it should help with this issue. Ideally the toolbar would recognise when its outside the browsers view point and adjust itself accordantly.

rollbackpt commented 11 years ago

That doesn't seem to hard to implement.

devmondo commented 11 years ago

sorry to nag, but does the above means it is fixed or it will be implemented ?

rollbackpt commented 11 years ago

will be implemented

devmondo commented 11 years ago

thank you

paulkinzett commented 11 years ago

Edge collision detection has now been added for the left and right edges.

devmondo commented 11 years ago

thank you

rollbackpt commented 11 years ago

Nice. Already did a quick test and seems fine. Have you considered the possibility of the left or right toolbar appear in the opposite side in case of edge collision? I know you will say: why you would put a left toolbar if you don't have space on the left? But you cannot predict some persons resolutions or window sizes. Wouldn't be better to have the toolbar visible even if it is on the wrong side?