paulkinzett / toolbar

A tooltip style toolbar jQuery plugin
http://paulkinzett.github.com/toolbar/
MIT License
2.3k stars 321 forks source link

hideOnClick feature missing on github code #6

Closed rollbackpt closed 11 years ago

rollbackpt commented 11 years ago

Why the version in the official site http://paulkinzett.github.com/toolbar/ has the hideOnClick function and and code on github doesn't?

    bindHideEvent: function() {

        var self = this;

        var hideEvent = "click.toolbar";

        if(self.options.hideOnClick) {
            $('html').off(hideEvent).on(hideEvent, function( event ) {
                if(self.toolbar.has(event.target).length === 0 ) {
                    self.hide();
                }
            });     
        }             

    },
rollbackpt commented 11 years ago

Already added that to my pull request in #5.

paulkinzett commented 11 years ago

Thanks for spotting this, your pull request has been merged.