paulkr / blowup.js

🔍 jQuery plugin for image magnification.
https://paulkr.github.io/blowup.js/
MIT License
92 stars 50 forks source link

Add mouse scroll event #20

Open MetaMmodern opened 4 years ago

MetaMmodern commented 4 years ago

Hi, I made some improvements to the library:

These changes were needed in my personal project, so I made that 2 years ago and forgot to propose a PR.

Further improvements may be:

I didn't know which tools did you use to minify this code, so the minified version is not changed. Please, minify it before merging)

Please, add a "hacktoberfest-accepted" label to this PR, thank you!

rfuehrer commented 2 years ago

Hi @MetaMmodern ,

it's a pity that you removed the reference to the author in a PR at the upstream itself. I personally find that disrespectful to the original author @paulkr . Especially since we all have an advantage from this good preliminary work.

I think your idea and impulse are excellent, but found that scrolling with a logitech mouse activated screen scrolling. This is because the event mousewheel in Firefox is already deprecated. It is to use wheel instead (source: https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event and https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event).

I took the freedom to update your code locally, as the DOM events will be triggered via "wheel" under Firefox in 2021. Also, as a precaution, the default is disabled while the event is triggered. Tested with Safari and Firefox.

Maybe you are interested in an update of your mentioned project and this PR?

}) $element.bind('wheel', function (e) { e.preventDefault(); if (e.originalEvent.wheelDelta / 120 > 0) {

MetaMmodern commented 2 years ago

Hi @MetaMmodern ,

it's a pity that you removed the reference to the author in a PR at the upstream itself. I personally find that disrespectful to the original author @paulkr . Especially since we all have an advantage from this good preliminary work.

I think your idea and impulse are excellent, but found that scrolling with a logitech mouse activated screen scrolling. This is because the event mousewheel in Firefox is already deprecated. It is to use wheel instead (source: https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event and https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event).

I took the freedom to update your code locally, as the DOM events will be triggered via "wheel" under Firefox in 2021. Also, as a precaution, the default is disabled while the event is triggered. Tested with Safari and Firefox.

Maybe you are interested in an update of your mentioned project and this PR?

}) $element.bind('wheel', function (e) { e.preventDefault(); if (e.originalEvent.wheelDelta / 120 > 0) {

Lol, dude, this repo is dead.

rfuehrer commented 2 years ago

...ok, I agree with you, this is not great handled by @paulkr. But for that we can set up forks ;)

At least @paulkr iis still active and that gives me hope that reasonable PRs are accepted or at least by activity @paulkr marks the repo as deprecated. Also @MetaMmodern your PR was worth a lot and therefore thank you both. No matter if the project looks dead or not. Maybe my comment will help others also :D