paullouisageneau / datachannel-wasm

C++ WebRTC Data Channels and WebSockets for WebAssembly in browsers
MIT License
148 stars 25 forks source link

Fixing rtcCreatePeerConnection #15

Closed hanseuljun closed 3 years ago

hanseuljun commented 3 years ago

Add second parameter to rtcCreatePeerConnection from the c++ side, which was missing.

Previously, nIceServers was undefined from the javascript side. What happened was since nIceServers is undefined, i < nIceServers was always false, so the for loop of rtcCreatePeerConnection was skipped.