It appears dynCall has been converted into a library function in https://github.com/emscripten-core/emscripten/issues/12002 therefore datachannel-wasm should add an explicit dependency on '$dynCall' to ensure it is present at runtime.
However, it seems better to remove the reliance on the dynCall API entirely. This PR replaces dynamic dynCall usage by the makeDynCall macro, as the macro looks widely used in emscripten JS libraries and is de-facto public as explained in https://github.com/emscripten-core/emscripten/pull/12732. It removes the dependency on the runtime method and should perform better.
It appears
dynCall
has been converted into a library function in https://github.com/emscripten-core/emscripten/issues/12002 therefore datachannel-wasm should add an explicit dependency on'$dynCall'
to ensure it is present at runtime.However, it seems better to remove the reliance on the
dynCall
API entirely. This PR replaces dynamicdynCall
usage by themakeDynCall
macro, as the macro looks widely used in emscripten JS libraries and is de-facto public as explained in https://github.com/emscripten-core/emscripten/pull/12732. It removes the dependency on the runtime method and should perform better.Fixes the possible need for
-sDYNCALLS=1
described in https://github.com/paullouisageneau/datachannel-wasm/issues/38