paullouisageneau / libdatachannel

C/C++ WebRTC network library featuring Data Channels, Media Transport, and WebSockets
https://libdatachannel.org/
Mozilla Public License 2.0
1.73k stars 353 forks source link

Complilation failure. Cmake. #1034

Closed DGISystem closed 10 months ago

DGISystem commented 10 months ago

Hello, so I got this trying to compile (rbfx, uses libdatachannel). Does anyone have any ideas?, I don't. :) thanks. Version of libdatachannel is "git clone" as of ~8hrs ago.

In file included from /home/hbh/code/rbfx/Source/ThirdParty/libdatachannel/src/impl/wshandshake.cpp:9:
/home/hbh/code/rbfx/Source/ThirdParty/libdatachannel/src/impl/wshandshake.hpp:35:28: error: expected class name
        class Error : public std::runtime_error {
                                  ^
/home/hbh/code/rbfx/Source/ThirdParty/libdatachannel/src/impl/wshandshake.cpp:277:46: error: type 'std::runtime_error' is not a direct or virtual base of 'rtc::impl::WsHandshake::Error'
WsHandshake::Error::Error(const string &w) : std::runtime_error(w) {}
                                             ^~~~~~~~~~~~~~~~~~
2 errors generated.
make[2]: *** [Source/ThirdParty/libdatachannel/CMakeFiles/datachannel-static.dir/build.make:804: Source/ThirdParty/libdatachannel/CMakeFiles/datachannel-static.dir/src/impl/wshandshake.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2846: Source/ThirdParty/libdatachannel/CMakeFiles/datachannel-static.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
DGISystem commented 10 months ago

My assumption about rbfx using fresh libdatachannel version was wrong. It was an older version of libdatachannel just copy-pasted in rbfx repository. Probably this is the issue (checking rn). My bad, sorry.

edit: yep, not a libdatachannel problem, just old\modified ver. Issue resolved. Sorry, my mistake.