SctpTransport::SendCallback

paullouisageneau / libdatachannel

C/C++ WebRTC network library featuring Data Channels, Media Transport, and WebSockets

https://libdatachannel.org/

Mozilla Public License 2.0

1.81k stars 365 forks source link

SctpTransport::SendCallback #168

Closed Nemirtingas closed 4 years ago

Nemirtingas commented 4 years ago

Hi, Looks like your SctpTransport::SendCallback in sctptransport.hpp is missing a void* ulp_info

paullouisageneau commented 4 years ago

Did you update deps/usrsctp yourself to the last master? The build is supposed to work only with the correct submodules versions in the tree.

You can reset usrsctp at the proper commit with git submodule update --recursive.

Nemirtingas commented 4 years ago

Ah yes, I did that. Is it preferable to use the version that is pulled by submodule update or I can use the latest master version ?

paullouisageneau commented 4 years ago

It's preferable to use the version pulled by submodule update, since the latest master can break the API or introduce incompatibilities (libdatachannel relies on some more or less hacky mitigations to have usrsctp working properly).